ci(amazonq): fix linting issue on language server child process #6332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nkomonen-amazon
approved these changes
Jan 10, 2025
justinmk3
reviewed
Jan 13, 2025
| import vscode, { env, version } from 'vscode' | ||
| import * as nls from 'vscode-nls' | ||
| import * as cp from 'child_process' | ||
| import * as cp from 'child_process' // eslint-disable-line no-restricted-imports -- language server options expect actual child process |
Contributor
There was a problem hiding this comment.
We could add something like ChildProcess.proc to return the nodejs object?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In a recent PR we disabled using child_process in favour of our internal one. This started flagging lsp/client.ts, since it wasn't skipped.
Solution
Skip eslint for child_process in this case, since the language server options expect the actual child process. The same is done for the workspace context language server: https://github.com/aws/aws-toolkit-vscode/blob/master/packages/core/src/amazonq/lsp/lspClient.ts#L13
feature/xbranches will not be squash-merged at release time.